Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clean subcommand #664

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Implement clean subcommand #664

merged 4 commits into from
Jul 25, 2022

Conversation

wx257osn2
Copy link
Contributor

No description provided.

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I put some nitpicks.

lib/cmd/clean.cc Outdated Show resolved Hide resolved
lib/cmd/clean.cc Outdated Show resolved Hide resolved
lib/cmd/clean.cc Outdated Show resolved Hide resolved
lib/cmd/clean.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #664 (7f04ceb) into main (11d2a27) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          52       52           
  Lines        2527     2527           
=======================================
  Hits         2481     2481           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d2a27...7f04ceb. Read the comment docs.

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for taking your time to work on this change!

@ken-matsui ken-matsui merged commit 740b8a0 into main Jul 25, 2022
@ken-matsui ken-matsui deleted the implement-clean-subcommand branch July 25, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants